-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Chrome v140 workaround - Replace multiple select in onboard logging #4614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome v140 workaround - Replace multiple select in onboard logging #4614
Conversation
WalkthroughSwitches the Blackbox debug-fields selector from a multi-select to a checkbox table UI, updating the bitmask in real time via checkbox changes instead of on Save. Updates the English locale label for the section. Corresponding HTML is restructured to host a table for dynamic rows. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant UI as Debug Fields Table (checkboxes)
participant BB as FC.BLACKBOX
participant Save as Save Action
rect rgb(245,245,255)
note right of UI: New flow: real-time updates
U->>UI: Toggle checkbox for field i
UI->>BB: Update blackboxDisabledMask bit i (set/clear)
UI-->>U: Checkbox reflects current state
end
rect rgb(245,255,245)
note right of Save: Save persists current mask
U->>Save: Click "Save Settings"
Save->>BB: Read current blackboxDisabledMask
Save-->>U: Save complete
end
sequenceDiagram
participant U as User
participant MS as Multi-select (old)
participant BB as FC.BLACKBOX
participant Save as Save Action
note right of MS: Old flow (removed)
U->>MS: Select/deselect fields
U->>Save: Click "Save Settings"
Save->>MS: Read selected options
Save->>BB: Compute and assign blackboxDisabledMask
Save-->>U: Save complete
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Pre-merge checks❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
|
05bcac8 to
2d87ab9
Compare
2d87ab9 to
4574e92
Compare
|
|
Preview URL: https://4574e923.betaflight-configurator.pages.dev |
nerdCopter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice



Summary by CodeRabbit